Hi Jonathan
On 29/09/2023 22:20, Jonathan Tan wrote:
From: Calvin Wan <calvinwan@xxxxxxxxxx>
remove_or_warn() is only used by entry.c and apply.c, but it is
currently declared and defined in wrapper.{h,c}, so it has a scope much
greater than it needs. This needlessly large scope also causes wrapper.c
to need to include object.h, when this file is largely unconcerned with
Git objects.
Move remove_or_warn() to entry.{h,c}. The file apply.c still has access
to it, since it already includes entry.h for another reason.
This looks good. On a related note wrapper.c includes repository.h but
does use anything declared in that header.
Best Wishes
Phillip
