On Sun, Oct 08, 2023 at 04:35:23PM +0200, SZEDER Gábor wrote:
> > Hmm. I am confused -- are you saying that this series breaks existing
> > functionality, or merely does not patch an existing breakage? I *think*
> > that it's the latter,
>
> It's neither: the new functionality added in this series is broken.
>
> > since this test case fails identically on master,
> > but I am not sure.
>
> Not sure what test you are referring to. My test demonstrating the
> breakage succeeds when adaped to master, because master doesn't
> understand the commitgraph.changedPathsVersion=2 setting, and keeps
> writing v1 Bloom filter chunks instead, so all commit-graphs layers
> contain the same version.
I was referring to the test you sent back in:
https://public-inbox.org/git/20201015132147.GB24954@xxxxxxxxxx/
but I think that I should have been looking at the one you sent more
recently in:
https://lore.kernel.org/git/20230830200218.GA5147@xxxxxxxxxx/
Thanks,
Taylor
