Okay then, I'd wait for additional feedback and send in a Version 2 later. Thank you On Mon, Oct 9, 2023 at 9:03 AM Christian Couder <christian.couder@xxxxxxxxx> wrote: > > On Mon, Oct 9, 2023 at 9:46 AM Naomi Ibe <naomi.ibeh69@xxxxxxxxx> wrote: > > > > Okay I understand it better now ,can I do anything about it? Or should > > I leave it as is?. > > I think you should send a version 2 of the patch (so without a cover > letter) taking into account the comments I made about it. You might > want to wait a bit before sending version 2 though, so that others > might have time to read your patch and give you more feedback about > it. > > > It's my first time using the "git patch > > I guess you mean `git format-patch`. > > > and "git send-email" > > commands, so it was a real struggle understanding the proper way to > > get things setup. > > Yeah, it's not easy to set things up, but once that's done it should > be much easier. To make things even easier, you could perhaps save > somewhere the commands that you have previously used. And to improve > or make changes to those commands, you could take a look at the > documentation for `git format-patch` and `git send-email` which have a > number of interesting options, and take note of those interesting > options.
