On Thu, Oct 5, 2023 at 10:46 AM Patrick Steinhardt <ps@xxxxxx> wrote: > On Tue, Oct 03, 2023 at 05:54:19PM -0400, Taylor Blau wrote: > > + /* The largest pack was repacked, meaning that either > > + * one or two packs exist depending on whether the > > + * repository has a cruft pack or not. > > Nit: this comment will grow stale soonish once your patch series lands > that introduces a maximum packfile size for cruft packs as there can be > arbitrarily many cruft packs from thereon. > > The rest of this patch series looks good to me and makes sense. I don't > really think that this comment here is worth a reroll. If you do happen to reroll for some reason, though, perhaps take care of the minor style violation, as well. Use: /* * Multi-line comment * style. */ rather than: /* Multi-line comment * style. */