Eric Sunshine <sunshine@xxxxxxxxxxxxxx> writes: > On Tue, Oct 3, 2023 at 1:49 PM <ach.lumap@xxxxxxxxx> wrote: >> t2400: avoid using pipes > > Pipes themselves are not necessarily problematic, and there are many > places in the test suite where they are legitimately used. Rather... > ... > readers of `git log --oneline` (or other such commands), a better > subject for the patch might be: > > t2400: avoid losing Git exit code > > That minor comment aside (which is probably not worth a reroll), the > commit message properly explains why this change is desirable and the > patch itself looks good. Thanks for writing and reviewing. Will queue.
