Re: [PATCH 2/2] parse-options: use and require int pointer for OPT_CMDMODE

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Am 21.09.23 um 12:40 schrieb Oswald Buddenhagen:
> On Wed, Sep 20, 2023 at 10:18:10AM +0200, René Scharfe wrote:
>> MSVC warns about all combinations.
>>
> yes, though that's not a problem: after we established that the
> underlying type is int, we can just have a cast in the initializer
> macro.

MSVC does some weird things in general; it's tempting to ignore it.

>>> so how about simply adding a (configure) test to ensure that
>>> there is actually no problem, and calling it a day?
>
>> If we base it on type size then we're making assumptions that I
>> find hard to justify.
>>
> the only one i can think of is signedness. i think this can be safely
> ignored as long as we use only small positive integers.

I don't fully understand the pointer-sign warning, so I'm not
confident enough to silence it.

René




[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux