On Oct 26, 2007, at 5:39 AM, Christian Couder wrote:
This is incompatible with previous versions because an exit code of 125 used to mark current commit as "bad". But hopefully this exit code is not much used by test scripts or other programs. (126 and 127 are used by bash.) Signed-off-by: Christian Couder <chriscool@xxxxxxxxxxxxx> --- Documentation/git-bisect.txt | 8 ++++++-- git-bisect.sh | 11 ++++++++++-t/t6030-bisect-porcelain.sh | 40 +++++++++++++++++++++++++++++++ +++++++++3 files changed, 56 insertions(+), 3 deletions(-)diff --git a/Documentation/git-bisect.txt b/Documentation/git- bisect.txtindex 785f381..14b7a95 100644 --- a/Documentation/git-bisect.txt +++ b/Documentation/git-bisect.txt @@ -183,13 +183,17 @@ $ git bisect run my_script Note that the "run" script (`my_script` in the above example) should exit with code 0 in case the current source code is good and with a -code between 1 and 127 (included) in case the current source code is -bad.+code between 1 and 127 (included), except 125 that is special, in case+the current source code is bad. Any other exit code will abort the automatic bisect process. (Aprogram that does "exit(-1)" leaves $? = 255, see exit(3) manual page,the value is chopped with "& 0377".) +The special exit code 125 should be used when the current source code+cannot be tested. If the "run" script exits with this code, the current+revision will be "skip"ped, see `git bisect skip` above. + You may often find that during bisect you want to have near-constant tweaks (e.g., s/#define DEBUG 0/#define DEBUG 1/ in a header file, or "revision that does not have this commit needs this patch applied to
Since exit 77 is already used by automake to mean "skip", wouldn't it be better to do the same thing here?
Cheers, -- Benoit Sigoure aka Tsuna EPITA Research and Development Laboratory
Attachment:
PGP.sig
Description: This is a digitally signed message part
