On Sun, Sep 24, 2023 at 09:59:00PM +0200, SZEDER Gábor wrote: > Besides the issue of not reading Bloom filter for root commits, that > message of mine also includes a test demonstrating that handling split > commit graph with layers containing different versions of Bloom > filters is broken. That test still fails with the current version of > this patch series, i.e. what is currently in seen. Jonathan provided > a patch that makes that test pass, and also noted that that test did > pass with his original design: > > https://public-inbox.org/git/20230901205616.3572722-1-jonathantanmy@xxxxxxxxxx/ I am not sure whether you are pointing out an existing breakage which remains unfixed, or pointing out a new bug introduced by this series. I think that it is the former, but I wrote up some of my confusion in: https://lore.kernel.org/git/ZRIRtlbsYadg7EUx@nand.local/ > I maintain that without test cases thoroughly covering the interaction > of different Bloom filter versions with split commit graphs this > series should not be merged. Agreed. We should wait for the discussion in the linked thread to settle before merging this down. Thanks, Taylor
