Junio C Hamano <gitster@xxxxxxxxx> wrote:
> > * two spaces after periods for sentences
>
> Although I admit I tend to hit my spacebar twice after a sentence, I
> think more people tend to just do with a single space and let the
> formatting software (like AsciiDoc) take care of the inter-sentence
> spacing. To me, this falls into "it would be nicer if we did this
> when we write a new sentence, but it is not worth the patch noise if
> somebody already wrote with a single space to change them" category.
> The title of the patch may have been written after you did the
> above, but now it includes other changes listed below, so it may
> want to be revised.
Indeed.
Would it get revised or just abandoned in favor of something else?
> > * comma (before/)after `i.e.` and `e.g.`
>
> That's modern American English. I think our documentation is
> mixture so this may also fall into "if it is already written that
> way, it is not worth the patch noise to change" category.
>
> > * comma after `etc.` when not ending a sentence
>
> There is one instance that says "A, B, C, D, etc., are all accepted."
> without the comma after 'etc.' and the patch corrects it. OK.
It seems like this is the only change that's of interest.
Do I just make a distinct gitgitgadget PR with that change, or do I
ask it to mark that single change as a V2 to this? (given the branch
name assumed whitespace and the only change would be a comma, it'd be
kinda wrong...)
> > * space before `(`
>
> If you mean by the above that we used to say
>
> ... as described below(see linkgit:git-config[1]))
>
> and you added a SP before "(see", that is a definite improvement. I
> however didn't find an example of a line that lacks SP before '('
> that got corrected to have a SP there.
I'm pretty sure that's what I meant, but I can't find the change in my
git reflog, and I'm not quite sure how I could have made that mistake.
