On Fri, Sep 22, 2023 at 10:38:06PM +0200, Rubén Justo wrote: > [...] > Let's add the missing conditions in the if-elses chain to make it work > as expected. Thanks, I think this explains the situation better than the original. > + elif test "$test_failure" = 0 > + then > say "With GIT_TEST_SANITIZE_LEAK_LOG=true our logs revealed a memory leak, exit non-zero!" && > invert_exit_code=t > + else > + say "With GIT_TEST_SANITIZE_LEAK_LOG=true our logs revealed a memory leak..." > fi OK, so you did add in the "else" here. :) I am obviously fine with that, and the patch overall looks good to me. -Peff
