Jonathan Tan <jonathantanmy@xxxxxxxxxx> writes: > Calvin Wan <calvinwan@xxxxxxxxxx> writes: >> Add test file that directly or indirectly calls all functions defined in >> git-std-lib.a object files to showcase that they do not reference >> missing objects and that git-std-lib.a can stand on its own. >> >> Certain functions that cause the program to exit or are already called >> by other functions are commented out. >> >> TODO: replace with unit tests >> Signed-off-by: Calvin Wan <calvinwan@xxxxxxxxxx> > > I think the TODO should go into the code, so that when we add a unit > test that also deletes stdlib-test.c, we can see what's happening just > from the diff. The TODO should also explain what stdlib-test.c is hoping > to do, and why replacing it is OK. (Also, do we need to invoke all the > functions? I thought that missing functions are checked at link time, or > at the very latest, when the executable is run. No need to change this, > though - invoking all the functions we can is fine.) > Thanks for excellent reviews (not just against this 6/6 but others, too).
