On Fri, Sep 15, 2023 at 07:32:37AM -0400, Jeff King wrote:
> (If anyone wants to confirm the bug or test, the new version of curl
> just hit debian unstable).
These two patches look sensible, and I can confirm that they resolve the
issue with the newest version of curl. With the latest 'master' (which
is bda494f404 (The ninth batch, 2023-09-14), at the time of writing) and
an old version of curl, I get:
$ ./t5559-http-fetch-smart-http2.sh -vdi
[...]
expecting success of 5559.17 'GIT_TRACE_CURL redacts auth details':
rm -rf redact-auth trace &&
set_askpass user@host pass@host &&
GIT_TRACE_CURL="$(pwd)/trace" git clone --bare "$HTTPD_URL/auth/smart/repo.git" redact-auth &&
expect_askpass both user@host &&
# Ensure that there is no "Basic" followed by a base64 string, but that
# the auth details are redacted
! grep -i "Authorization: Basic [0-9a-zA-Z+/]" trace &&
grep -i "Authorization: Basic <redacted>" trace
Cloning into bare repository 'redact-auth'...
remote: Enumerating objects: 6, done.
remote: Counting objects: 100% (6/6), done.
remote: Compressing objects: 100% (2/2), done.
remote: Total 6 (delta 0), reused 0 (delta 0), pack-reused 0
Receiving objects: 100% (6/6), done.
== Info: [HTTP/2] [3] [authorization: Basic dXNlckBob3N0OnBhc3NAaG9zdA==]
== Info: [HTTP/2] [5] [authorization: Basic dXNlckBob3N0OnBhc3NAaG9zdA==]
== Info: [HTTP/2] [7] [authorization: Basic dXNlckBob3N0OnBhc3NAaG9zdA==]
not ok 17 - GIT_TRACE_CURL redacts auth details
#
# rm -rf redact-auth trace &&
# set_askpass user@host pass@host &&
# GIT_TRACE_CURL="$(pwd)/trace" git clone --bare "$HTTPD_URL/auth/smart/repo.git" redact-auth &&
# expect_askpass both user@host &&
#
# # Ensure that there is no "Basic" followed by a base64 string, but that
# # the auth details are redacted
# ! grep -i "Authorization: Basic [0-9a-zA-Z+/]" trace &&
# grep -i "Authorization: Basic <redacted>" trace
#
and after applying these patches, those tests pass.
$ ./t5559-http-fetch-smart-http2.sh -di
[...]
# passed all 54 test(s)
1..54
Thanks,
Taylor
