Junio C Hamano <gitster@xxxxxxxxx> writes:
> "Linus Arver via GitGitGadget" <gitgitgadget@xxxxxxxxx> writes:
>
>> From: Linus Arver <linusa@xxxxxxxxxx>
>>
>> [...]
>> So instead of using "*_DEFAULT", use "*_UNSPECIFIED" because this
>> signals to the reader that the *_UNSPECIFIED value by itself carries no
>> meaning (it's a zero value and by itself does not "default" to anything,
>> necessitating the need to have some other way of getting to a useful
>> value).
>
> It gets tempting to initialize a variable to the default and arrange
> the rest of the system so that the variable set to the default
> triggers the default activity. Such an obvious solution however
> cannot be used when (1) being left unspecified to use the default
> value and (2) explicitly set by the user to a value that happens to
> be the same as the default have to behave differently. I am not
> sure if that applies to the trailers system, though.
>
> Thanks.
I get the feeling that you wrote the "Such an obvious ... differently"
sentence after writing the last sentence in that paragraph, because when
you say
I am not
sure if that applies to the trailers system, though.
I read the "that" (emphasis added) in there as referring to the solution
described in the first sentence, and not the conditions (1) and (2) you
enumerated. IOW, you are OK with this patch.
Am I parsing your paragraph correctly?
> PS. Glen's old e-mail address is no longer valid and there is no
> forwarding done by @google.com mailservers, it seems. Can you tell
> GGG to drop the address (optionally replace it with his new address)?
Thanks for catching this. I've updated the GGG PR [1] to use Glen's new
address.
[1] https://github.com/gitgitgadget/git/pull/1563#issue-1837440424
