Oswald Buddenhagen <oswald.buddenhagen@xxxxxx> writes: > The given test name made no sense to me at all; it seems to be a > concatenation of two unrelated things. This was introduced by > commit 0c164ae7a ("rebase -i: add another reword test", 20-08-20). > > Signed-off-by: Oswald Buddenhagen <oswald.buddenhagen@xxxxxx> > > --- > actually, i don't understand what the test even does. shouldn't it, to > match the description, actually dirty the tree and verify that the > operation fails? > > Cc: Phillip Wood <phillip.wood@xxxxxxxxxxxxx> As a typofix the updated text looks more correct, but the above is a very good point, so I'll let Phillip, whose 0c164ae7 (rebase -i: add another reword test, 2021-08-20) introduced this test, react first. Thanks for spotting and fixing. > --- > t/t3404-rebase-interactive.sh | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/t/t3404-rebase-interactive.sh b/t/t3404-rebase-interactive.sh > index 96a56aafbe..31ee5bc1f6 100755 > --- a/t/t3404-rebase-interactive.sh > +++ b/t/t3404-rebase-interactive.sh > @@ -758,7 +758,7 @@ test_expect_success 'reword' ' > git show HEAD~2 | grep "C changed" > ' > > -test_expect_success 'no uncommited changes when rewording the todo list is reloaded' ' > +test_expect_success 'no uncommitted changes when rewording' ' > git checkout E && > test_when_finished "git checkout @{-1}" && > (