Hi Christian & Elijah, On Thu, 7 Sep 2023, Christian Couder wrote: > From: Elijah Newren <newren@xxxxxxxxx> > > Let's set the rev walking options we need after calling > setup_revisions() instead of before. This makes it clearer which options > we need. In light of the currently open issue about command-line validation, this change does more than this paragraph lets on: It hardcodes certain settings, overriding (silently) any rev-list options the user might have passed. Is there any chance that we can avoid this change? > Also we don't want history simplification, as we want to deal with all > the commits in the affected range. This, however, is a good change. It deserves to live in its own commit, with its own commit message, in particular because it is not obvious from the attribute names which ones we're talking about (I guess it's `limited` and `simplify_history`, not just the latter. Ciao, Johannes
