On Sat, Sep 02, 2023 at 08:20:28AM +0200, René Scharfe wrote:
> > static struct option builtin_merge_options[] = {
> > - OPT_CALLBACK_F('n', NULL, NULL, NULL,
> > - N_("do not show a diffstat at the end of the merge"),
> > - PARSE_OPT_NOARG, option_parse_n),
> > + OPT_SET_INT('n', NULL, &show_diffstat,
> > + N_("do not show a diffstat at the end of the merge"), 0),
> > OPT_BOOL(0, "stat", &show_diffstat,
> > N_("show a diffstat at the end of the merge")),
>
> Makes it easier to see that we can replace the two complementary
> definitions with a single one:
>
> OPT_NEGBIT('n', "no-stat",
> N_("do not show a diffstat at the end of the merge"), 1),
>
> Which is a separate topic, of course. And if we did that, however, ...
Ah, I thought we had a "reverse bool" of some kind, but I couldn't find
it. NEGBIT was what I was looking for. But yeah, I agree it gets more
complicated with the various aliases. I think what I have here is a good
stopping point for this series, but if you want to go further on it, be
my guest. :)
-Peff
