On Wed, Aug 30, 2023 at 03:32:08PM -0700, Junio C Hamano wrote: > > True. Let me drop the patch from the 'next down to master > > fast-track' candidate status. > > We did the above but then everybody seems to have forgotten about > it. Let's resurrect the topic. Here is my attempt. > > ---- >8 ---- > From: Wesley Schwengle <wesleys@xxxxxxxxxxxxxxx> > Subject: [PATCH] git-svn: drop FakeTerm hack > > Drop the FakeTerm hack, just like dfd46bae (send-email: drop > FakeTerm hack, 2023-08-08) did, for exactly the same reason. Yep, it looks good to me. Optionally you could add this to the commit message: It has been obsolete in git-svn since 30d45f798d (git-svn: delay term initialization, 2014-09-14). Note that unlike send-email, we already make sure to load Term::ReadLine only once. So this is just a cleanup, and not fixing any bug. -Peff
