On Wed, Oct 24, 2007 at 09:41:30PM -0700, Junio C Hamano wrote: > Scott R Parish <srp@xxxxxxxxxxxx> writes: > > > list_commands() currently accepts and ignores a "pattern" argument, > > and then hard codes a prefix as well as some magic numbers. > > Correct observation. > > Personally, I find this static function should not pretend to be > as flexible --- it is to list git subcommands anyway (and it > even knows about ".exe"), so rather than renaming the pattern > and using it, it might be simpler and cleaner to just drop the > parameter and be done with it. Nice, i like that even better sRp -- Scott Parish http://srparish.net/ - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
