Jonathan Tan <jonathantanmy@xxxxxxxxxx> writes: > I mistakenly sent my reply to an earlier version [1]. (Taylor has seen > it, so this note is more for future readers who might be curious about > what that email reply contains.) > > [1] https://lore.kernel.org/git/20230824222051.2320003-1-jonathantanmy@xxxxxxxxxx/ I think that this patch set is good for merging. There is a discussion between Taylor and me at the link above in which Taylor thinks something is OK and I think that that thing is OK except in a very specific situation (there exists a commit-graph chain in which the different layers have different Bloom filter versions). (Hopefully that's a good summary of the discussion.) I think that the situation is narrow enough and have seen that Taylor (whose capabilities I have a high opinion of) has looked into it. I think the only way for me to be fully convinced is to write a test that includes these different layers and see how the code functions. So I think that we can merge this patch set. An alternative would be to wait for me (or someone else) to write such a test, but if it's just me that's worried about this situation, it's probably not worth waiting just for this. The other outstanding thing is that Szeder Gabor pointed out that Bloom filters are not applied to root commits so some of the tests don't test what you would expect [2]. I've updated the tests and pushed the results to GitHub [3]. I'm OK with using that version, or the current version (in which case I'll resend the updated tests once this version is merged). [2] https://lore.kernel.org/git/20230826150610.GA1928@xxxxxxxxxx/ [3] https://github.com/jonathantanmy/git/tree/changedpath
