I'm back with another exciting installment of -Wunused-parameter warning fixes. Most of these are pretty boring and obvious; the first two are the most interesting in terms of rationale. I promise we're closing in on the finish line here. I only have about 20 patches left after this, at which point we should be able to turn on the warning by default for developer builds. [01/22]: sequencer: use repository parameter in short_commit_name() [02/22]: sequencer: mark repository argument as unused [03/22]: ref-filter: mark unused parameters in parser callbacks [04/22]: pack-bitmap: mark unused parameters in show_object callback [05/22]: worktree: mark unused parameters in each_ref_fn callback [06/22]: commit-graph: mark unused data parameters in generation callbacks [07/22]: ls-tree: mark unused parameter in callback [08/22]: stash: mark unused parameter in diff callback [09/22]: trace2: mark unused us_elapsed_absolute parameters [10/22]: trace2: mark unused config callback parameter [11/22]: test-trace2: mark unused argv/argc parameters [12/22]: grep: mark unused parameter in output function [13/22]: add-interactive: mark unused callback parameters [14/22]: negotiator/noop: mark unused callback parameters [15/22]: worktree: mark unused parameters in noop repair callback [16/22]: imap-send: mark unused parameters with NO_OPENSSL [17/22]: grep: mark unused parmaeters in pcre fallbacks [18/22]: credential: mark unused parameter in urlmatch callback [19/22]: fetch: mark unused parameter in ref_transaction callback [20/22]: bundle-uri: mark unused parameters in callbacks [21/22]: gc: mark unused descriptors in scheduler callbacks [22/22]: update-ref: mark unused parameter in parser callbacks add-interactive.c | 8 ++++---- builtin/fetch.c | 2 +- builtin/gc.c | 6 +++--- builtin/ls-tree.c | 3 ++- builtin/stash.c | 2 +- builtin/update-ref.c | 14 +++++++------- builtin/worktree.c | 8 ++++---- bundle-uri.c | 6 +++--- commit-graph.c | 8 +++++--- credential.c | 4 ++-- grep.c | 12 +++++++----- imap-send.c | 10 ++++++++-- negotiator/noop.c | 12 +++++++----- pack-bitmap.c | 5 +++-- ref-filter.c | 8 +++++--- sequencer.c | 27 ++++++++++++++------------- t/helper/test-trace2.c | 6 +++--- trace2/tr2_sysenv.c | 3 ++- trace2/tr2_tgt_event.c | 23 +++++++++++++---------- trace2/tr2_tgt_normal.c | 20 ++++++++++++-------- worktree.c | 6 ++++-- 21 files changed, 110 insertions(+), 83 deletions(-) -Peff
