On Tue, 22 Aug 2023, Junio C Hamano wrote:
The following is admittedly a very blunt workaround to disable HTTP/2 for
the affected versions for any purpose, but I wonder if it is an acceptable
workaround. The remote-curl transport helper is used for both push and
fetch and I didn't find a good place to automatically force the protocol
version only for pushes.
The downside with this approach is that you make it build-time. Since libcurl
8.2.x is binary compatible with the previous versions, users could easily
upgrade to a newer libcurl without rebuilding git and then unnecessarily have
the avoid-h2 code still used.
The ideal approach would do the check in run-time to avoid that.
Wether the problem is serious enough to actually warrant such a work-around in
the first place, I really cannot say.
--
/ daniel.haxx.se
