Jeff King <peff@xxxxxxxx> writes: > The end result looks good to me. I probably would have squashed at least > 2+4 into one, and probably just squashed 3 into that as well. But I am > OK with it as-is, too, and it is definitely diminishing returns to keep > polishing it. I had the same impression. The endgame after applying all four looks very sensible but the changes necessary to fix things while keeping ZERO_EXISTS and NUMBER_EXISTS looked more or less like unnecessary detour. > Thanks for assembling it into a usable form. Yup. Will queue almost as-is (except for dropping the repeated "commit-graph" on the title of the last step). THanks.
