On Fri, Aug 11, 2023 at 12:28:49PM -0700, Junio C Hamano wrote: > Jeff King <peff@xxxxxxxx> writes: > > > This applies on top of yours, but probably would replace patches 2, 4, > > and 5 (the flip-flop case isn't even really worth testing after this, > > since the message can obviously only be shown once). > > > > commit-graph.c | 42 +++++++++-------------------------- > > t/t5318-commit-graph.sh | 18 ++------------- > > 2 files changed, 13 insertions(+), 47 deletions(-) > > Quite an impressive amount of code reduction. I obviously like it. > > One very minor thing is that how much value are we getting by > reporting the object names of one example from each camp, instead of > just reporting a single bit "we have commits not counted and also > counted their generations, which is an anomaly". > > Obviously it does not matter. Even if we stopped doing so, the code > would not become much simpler. We'd just use a word with two bits > instead of two pointers to existing in-core objects, which does not > have meaningful performance implications either way. Yeah, I wasn't sure if the commit names were valuable or not. Two bits would definitely work (though I have a slight preference for two boolean variables, just because I find the syntax easier to read). I don't think we've heard from Taylor, but I saw his original patches were in 'next'. I'm happy to clean up what I posted, but I'm also happy if we just merge what's in next and move on. -Peff
