Calvin Wan <calvinwan@xxxxxxxxxx> writes: > In order for date.c to be included in git-std-lib, the dependency to > pager.h must be removed since it has dependencies on many other files > not in git-std-lib. We achieve this by passing a boolean for > "pager_in_use", rather than checking for it in parse_date_format() so > callers of the function will have that dependency. Instead of doing it as you describe here, could this be another stub instead? That way, we don't need to change the code here. I don't feel strongly about this, though, so if other reviewers think that the approach in this patch makes the code better, I'm OK with that.