On 8/10/23 10:31, Junio C Hamano wrote:
Wesley Schwengle <wesleys@xxxxxxxxxxxxxxx> writes:
Subject: Re: [[PATCH v2]] Fix bug when more than one readline instance is used
Thanks. Again, our convention is to make sure that, even only with
the title, readers would know what the commit is about. The above
does not even hint which part of the system the bug was about. By
stealing from what Peff already has done, we can call this
Subject: [PATCH v2] git-svn: avoid creating more than one Term::ReadLine object
Ok. I'll keep that in mind for next time.
Once a commit is in 'next', its commit object name will generally be
stable, hence, taken as a whole, something like:
git-svn: avoid creating more than one than one Term::ReadLine object
Newer (v1.46) Term::ReadLine::Gnu would not like us to ask it to
create multiple readline instances. c016726c (send-email: avoid
creating more than one Term::ReadLine object, 2023-08-08)
adjusted git-send-email to this change. Make the same
adjustment to git-svn.
While at it, drop the same FakeTerm hack, just like dfd46bae
(send-email: drop FakeTerm hack, 2023-08-08) did, for exactly
the same reason.
I'll queue the patch with the above commit log message for tonight,
so unless you have improvements over it, there is no need to resend.
Thank you for your patience and accepting the patch(es).
Cheers,
Wesley
--
Wesley
Why not both?
