Re: [PATCH v3] rebase: clarify conditionals in todo_list_to_strbuf()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: [PATCH v3] rebase: clarify conditionals in todo_list_to_strbuf()
From: Oswald Buddenhagen <oswald.buddenhagen@xxxxxx>
Date: Thu, 10 Aug 2023 14:08:44 +0200
Cc: git@xxxxxxxxxxxxxxx, Taylor Blau <me@xxxxxxxxxxxx>, Phillip Wood <phillip.wood123@xxxxxxxxx>
In-reply-to: <xmqqbkfgm2di.fsf@gitster.g>
References: <20230428125601.1719750-1-oswald.buddenhagen@gmx.de> <20230807170935.2336745-1-oswald.buddenhagen@gmx.de> <xmqqv8dqd2bh.fsf@gitster.g> <ZNO7IVphPf8KOC3Q@ugly> <xmqqbkfgm2di.fsf@gitster.g>

On Wed, Aug 09, 2023 at 12:39:37PM -0700, Junio C Hamano wrote:

Thanks.  Then this patch is still a strict "Meh" to me.

i can't really think of a reason why you reject such a no-brainer otherthan that you consider it churn. in that case i need to tell you thatyou have unreasonable standards, which actively contribute to the coderemaining a mess.


regards

Follow-Ups:
- Re: [PATCH v3] rebase: clarify conditionals in todo_list_to_strbuf()
  - From: Junio C Hamano

References:
- [PATCH v2] rebase: clarify conditionals in todo_list_to_strbuf()
  - From: Oswald Buddenhagen
- [PATCH v3] rebase: clarify conditionals in todo_list_to_strbuf()
  - From: Oswald Buddenhagen
- Re: [PATCH v3] rebase: clarify conditionals in todo_list_to_strbuf()
  - From: Junio C Hamano
- Re: [PATCH v3] rebase: clarify conditionals in todo_list_to_strbuf()
  - From: Oswald Buddenhagen
- Re: [PATCH v3] rebase: clarify conditionals in todo_list_to_strbuf()
  - From: Junio C Hamano

Prev by Date: Re: [PATCH v3] sequencer: rectify empty hint in call of require_clean_work_tree()
Next by Date: Re: [PATCH v2 4/4] diff --no-index: support reading from named pipes
Previous by thread: Re: [PATCH v3] rebase: clarify conditionals in todo_list_to_strbuf()
Next by thread: Re: [PATCH v3] rebase: clarify conditionals in todo_list_to_strbuf()
Index(es):
- Date
- Thread

[Index of Archives] [Linux Kernel Development] [Gcc Help] [IETF Annouce] [DCCP] [Netdev] [Networking] [Security] [V4L] [Bugtraq] [Yosemite] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Linux SCSI] [Fedora Users]