Re: [PATCH] t9001: fix/unify indentation regarding pipes somewhat

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Aug 09, 2023 at 12:46:36PM -0700, Junio C Hamano wrote:
Oswald Buddenhagen <oswald.buddenhagen@xxxxxx> writes:
-	grep "=?UTF-8?q?=C3=A0=C3=A9=C3=AC=C3=B6=C3=BA?= <utf8@xxxxxxxxxxx>"
+		grep "=?UTF-8?q?=C3=A0=C3=A9=C3=AC=C3=B6=C3=BA?= <utf8@xxxxxxxxxxx>"

... I do not think we want this.  A long pipeline should be written
without extra indentation like

	A |
		B |
			C

... which is not how i would do it.

but more like

	A |
	B |
	C

i'd argue that this should be written as

	A |
		B |
		C

like other continued lines (no trailing backslashes are needed here, but it would be ok to add them, and there is in fact a commit that does just that in other places, and one might do the same here in a followup).

regards



[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux