On Tue, Aug 08, 2023 at 10:38:26AM +0200, Christian Couder wrote: > > I may be missing something, but what happens if the user has configured > > gc.repackFilter, but passes additional filters over the command-line > > arguments? I'm not sure whether these should be AND'd with the existing > > filters in config, or if they should reset them to zero, or something > > else. > > `git gc` doesn't recognize `--filter=<...>` arguments, only `git > repack` is being teached to recognize it in this patch series. So I > don't see how there could be multiple such arguments on the command > line when `git gc` is used. > > Also in version 4 `git repack` can be passed many such arguments > anyway. So I think we are good. Ah, thanks. Sorry for the misunderstanding :-). > We could support multiple gc.repackFilter config options, but on the > other hand using something like > `combine:<filter1>+<filter2>+...<filterN>` should work, as the content > of the option is passed as-is to the command line. So we can leave > that improvement for later if people don't like the `combine:...` and > are interested in it. I agree. To me it seems like there are probably relatively few people who would want to specify a multi-valued configuration directly when they could just use the "combine" trick you suggest. In either case, I agree that it can be done on top later. Thanks, Taylor
