On Wed, Aug 09, 2023 at 10:42:54AM -0700, Jacob Keller wrote:
> -v is a valid option to git format-patch:
>
> -v <n>, --reroll-count=<n>
> Mark the series as the <n>-th iteration of the topic. The
> output filenames have v<n> prepended to them, and the subject prefix
> ("PATCH" by
> default, but configurable via the --subject-prefix option)
> has ` v<n>` appended to it. E.g. --reroll-count=4 may produce
> v4-0001-add-makefile.patch file that has "Subject: [PATCH
> v4 1/20] Add makefile" in it. <n> does not have to be an integer
> (e.g.
> "--reroll-count=4.4", or "--reroll-count=4rev2" are
> allowed), but the downside of using such a reroll-count is that the
> range-diff/interdiff with
> the previous version does not state exactly which version
> the new interation is compared against.
>
> it takes a required argument, and inserts "v<argument>" into the
> [PATCH] block to describe the version.
Aaaah.
> Typically the argument should be a number, but you happened to provide
> it "--dry-run". Presumably assuming that the -v means "verbose" as it
> might in most other applications.
Yap.
> In short: this is working as intended, but it is somewhat confusing
> that it doesn't validate the argument at all. It is intentional to
> allow non-numeric strings, but maybe we ought to validate that it
> doesn't start with -- to avoid such confusion here.
Yes, the non-intuitiveness is kinda confusing.
> In short: -v doesn't mean verbose, it is a valid option, and while its
> a bit non-intuitive in this case, I think it is working as designed
> now.
Thanks for explaining!
:-)
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
