On 7/20/23 20:18, Junio C Hamano wrote:
Adam Majer <adamm@xxxxxxxxxxx> writes:
From 90be51143e741053390810720ba4a639c3b0b74c Mon Sep 17 00:00:00 2001
Remove all the above lines (including the "From <commit object
name>"). If you want to add a note that should not be recorded in
the message of the resulting commit, write it _after_ the three-dash
line after your sign-off.
Will do. I think the problem was `git format-patch` and then basically
pasting that inline instead of using it for basis of an email.
I will try again.
So, the body of the message usually should start from here (below).
+1
In general, please follow [[describe-changes]] part of the
Documentation/SubmittingPatches document, and also "git log
--no-merges" of recent contributions by others. "The purpose of
this patch is" is not how we usually talk about our work.
+1
And the message about SHA-256's non-experimental status can probably
be a lot stronger, after the discussion we had recently. How about
saying something like:
Note: there is no interoperability between SHA-256 repositories
and SHA-1 repositories right now. We historically warned that
SHA-256 repositories may need backward incompatible changes
later when we introduce such interoperability features, but at
this point we do not expect that we need to make such a change
when we do so, and the users can expect that their SHA-256
repositories they create with today's Git will be usable by
future versions of Git without losing information.
which would probably be much closer to what you wanted to hear?
Thanks, I've included additional context now, rebased on top of next
branch and will attach it as reply to this message.
- Adam
