Re: [PATCH] describe: fix --no-exact-match

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



René Scharfe <l.s.r@xxxxxx> writes:

> Since 2c33f75754 (Teach git-describe --exact-match to avoid expensive
> tag searches, 2008-02-24) git describe accepts --no-exact-match, but it
> does the same as --exact-match, an alias for --candidates=0.  That's
> because it's defined using OPT_SET_INT with a value of 0, which sets 0
> when negated as well.
>
> Let --no-exact-match set the number of candidates to the default value
> instead.  Users that need a more specific lack of exactitude can specify
> their preferred value using --candidates, as before.
>
> Suggested-by: Junio C Hamano <gitster@xxxxxxxxx>
> Signed-off-by: René Scharfe <l.s.r@xxxxxx>
> ---
> Or should we just forbid --no-exact-match?

We could do that, but setting it back to the default was also what I
did in my version I sent (<xmqqy1jcgbiv.fsf@gitster.g>) a few days
ago.




[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux