On 23/07/18 02:36PM, Phillip Wood wrote: > [...] > > The existing code is not consistent on this point but I think there are > more instances of " " than "\t". Using " " makes the indentation > consistent as the "hint: " prefix is translated so we don't know how far > the next tab stop will be from the end of the prefix. Agreed. > > [...] > > In the test we are redirecting the output to a file so things like tmux > do not come into play. I think it would be a bit odd for the system libc > to convert tabs to spaces. Understood. It was just a bit of paranoia on my part then. > [...] > > > Understood. I'll start working on a separate patch to update that > > warning once this patch settles then. > > That's great. I think just telling the user something like > > branch 'main' does not exist > > when HEAD contains the dangling symbolic ref "refs/heads/main" and > > HEAD is corrupt > > when it is not a symbolic ref and repo_get_oid() fails would be fine. Noted. I'll workshop it a bit before I put v1 of that patch out.
