On Thu, Jul 20, 2023 at 01:20:06PM -0700, Jonathan Tan wrote: > Having said that, I am inclined to not change this, so that the offset > calculations are the same for both versions (e.g. in the test tool > too), and as far as I know, we haven't had problems with this. But I can > change it if people want. Yeah, I definitely get your hesitation. I wonder if the test helper patches that I sent change your thinking on this at all, since then we're not relying on those scripts at all to compute the offset of the BDAT chunk and dump its contents. To be clear, I do think that this is probably outside the immediate scope of this series. But since we're changing the on-disk format and bumping the version count forward, I think that we want to make sure that we're not missing any other format changes that we'd like to make along the way. I suppose that a theoretical v3 of the BDAT chunk's format would use the same encoding for Bloom filters. But storing an extra 4-bytes of information in the header of the Bloom data chunk feels like we could squash that in. Thanks, Taylor
