Glad to have pointed out a possible improvement. :) By "different from others" I primarily meant that all the other hooks (save for fsmonitor-watchman, I guess) are safe to simply be "echo Hello world; exit 0" as they don't REPLACE any functionality. This one does. Perhaps there's a need for "pre-deploy" / "post-deploy" hooks, ensuring that it's a good time to deploy, maybe bringing a live website into and out of maintenance mode after the hopefully brief deployment..? On Wed, 19 Jul 2023 at 01:03, Junio C Hamano <gitster@xxxxxxxxx> wrote: > > "Adam \"Sinus\" Skawiński" <adam.skawinski@xxxxxxxxx> writes: > > > Oh. Then it's different from the other hooks, which merely enhance or > > abort the default behaviour by returning non-zero! I hadn't thought of > > that. > > I do not know if it is all that different from others, but in any > case it is a clear sign that the documentation needs a bit more love > to make sure that it will not lead new readers and users into the > same confusion. > > Thanks. -- Adam "Sinus" Skawiński
