On 14 Jul 2023, at 10:44, René Scharfe wrote: > Am 14.07.23 um 15:30 schrieb D. Ben Knoble via GitGitGadget: >> diff --git a/t/t4002-diff-basic.sh b/t/t4002-diff-basic.sh >> index d524d4057dc..7afc883ec37 100755 >> --- a/t/t4002-diff-basic.sh >> +++ b/t/t4002-diff-basic.sh >> @@ -403,7 +403,7 @@ test_expect_success 'diff-tree -r B A == diff-tree -r -R A B' ' >> git diff-tree -r -R $tree_A $tree_B >.test-b && >> cmp -s .test-a .test-b' >> >> -test_expect_success'diff can read from stdin' ' >> +test_expect_success 'diff can read from stdin' ' >> test_must_fail git diff --no-index -- MN - < NN | >> grep -v "^index" | sed "s#/-#/NN#" >.test-a && >> test_must_fail git diff --no-index -- MN NN | >> > > Good find! Introduced by 9cfcbcc095 (t4002-diff-basic: modernize test > format, 2023-05-18). Perhaps an automatic formatter would have avoided > it? E.g. some sed(1) scripting, or shfmt (https://github.com/mvdan/sh)? > (Just discovered shfmt, never used it.) Thanks for finding this and fixing! > > René
