On Tue, Jun 20, 2023 at 10:21:57AM -0400, Taylor Blau wrote: > In subsequent commits, it will be convenient to have a 'const char **' > of hidden refs (matching `transfer.hiderefs`, `uploadpack.hideRefs`, > etc.), instead of a `string_list`. > > Convert spots throughout the tree that store the list of hidden refs > from a `string_list` to a `strvec`. > > Note that in `parse_hide_refs_config()` there is an ugly const-cast used > to avoid an extra copy of each value before trimming any trailing slash > characters. This could instead be written as: > > ref = xstrdup(value); > len = strlen(ref); > while (len && ref[len - 1] == '/') > ref[--len] = '\0'; > strvec_push(hide_refs, ref); > free(ref); > > but the double-copy (once when calling `xstrdup()`, and another via > `strvec_push()`) is wasteful. I saw strvec_push_nodup() suggested here. I'm OK leaving it like this for now, but I do think we'll want that in the long run. -Peff
