Re: [PATCH v4 03/16] ref-filter: clear reachable list pointers after freeing

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Jun 20, 2023 at 10:21:11AM -0400, Taylor Blau wrote:

> From: Jeff King <peff@xxxxxxxx>
> 
> In reach_filter(), we pop all commits from the reachable lists, leaving
> them empty. But because we're operating on a list pointer that was
> passed by value, the original filter.reachable_from pointer is left
> dangling.

Yep. This isn't a bug (yet) because nobody looks at the now-dangling
pointer. So as with the last patch, we're future-proofing ourselves
against dangerous situations.

-Peff



[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux