Calvin Wan <calvinwan@xxxxxxxxxx> writes: > While string and environment value parsing is mainly consumed by > config.c, there are other files that only need parsing functionality and > not config functionality. By separating out string and environment value > parsing from config, those files can instead be dependent on parse, > which has a much smaller dependency chain than config. > > Move general string and env parsing functions from config.[ch] to > parse.[ch]. Quite sensible and ... > > Signed-off-by: Calvin Wan <calvinwan@xxxxxxxxxx> > --- > Makefile | 1 + > attr.c | 2 +- > config.c | 180 +----------------------------------- ... long overdue to have this. > config.h | 14 +-- > pack-objects.c | 2 +- > pack-revindex.c | 2 +- > parse-options.c | 3 +- > parse.c | 182 +++++++++++++++++++++++++++++++++++++ > parse.h | 20 ++++ > pathspec.c | 2 +- > preload-index.c | 2 +- > progress.c | 2 +- > prompt.c | 2 +- > rebase.c | 2 +- > t/helper/test-env-helper.c | 2 +- > unpack-trees.c | 2 +- > wrapper.c | 2 +- > write-or-die.c | 2 +- > 18 files changed, 219 insertions(+), 205 deletions(-) > create mode 100644 parse.c > create mode 100644 parse.h It is somewhat surprising and very pleasing to see so many *.c files had and now can lose dependency on <config.h>. Very nice.
