On 6/26/23 11:52, Junio C Hamano wrote:
Mark Levedahl <mlevedahl@xxxxxxxxx> writes:
I had originally organized as you suggest, no problem doing so
again. What gave me pause was this paragraph I originally wrote for
the cover letter:
Patches 1/2 cause git-gui to function as it has for the last decade on
Cygwin, but with Cygwin being detected. However, the browsing and
shortcut creation menu items, removed in 2012 then re-added when is_Cygwin
was fixed, do not work, and shortcut creation will crash git-gui if used.
These are fixed in patches 3 / 4.
As you are removing (ancient) Cygwin specific code that did not work
with modern Cygwin at all in step [2/4], it is not so unexpected
that some stuff does still not work after that step. I am not sure
what your reservation exactly is, but if you are wondering if code
to disable browsing and shortcut creation on Cygwin temporarily
needs to be there in the same step (instead of crashing or not
working), it may make sense if and only if it is done with minimal
changes.
Thanks.
Timely response ... yes, that was my concern. I resolved this by making
the cover letter and patch 2 commit message explicit that broken code
remains.
Thank you,
Mark
