Design issue in git merge driver interface
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- Subject: Design issue in git merge driver interface
- From: Joshua Hudson <jhudson@xxxxxxxxxxx>
- Date: Thu, 22 Jun 2023 09:50:01 -0700
- User-agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.11.2
We had a major incident here involving bad merges. It was traced to a
problem with a custom merge driver.
On studying why the merge driver failed, we found it was in an
unrunnable state (the logical equivalent of calling abort()) and could
not mark files as conflicted. Since the users were using a graphical
frontend the error messages disappeared into the bitbucket.
I've come to the definite conclusion that treating the file as
conflicted was wrong and the merge needed to bail out in the middle as
though git merge itself bombed. But there doesn't seem to be any way in
the protocol to actually do it.
Looking at the merge driver found that some things cannot be handled,
such as OOM condition. The fault has to propagate upwards, unwinding as
it goes.
[Index of Archives]
[Linux Kernel Development]
[Gcc Help]
[IETF Annouce]
[DCCP]
[Netdev]
[Networking]
[Security]
[V4L]
[Bugtraq]
[Yosemite]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Linux SCSI]
[Fedora Users]