Re: [PATCH v3 02/12] urlmatch.h: use config_fn_t type

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



"Glen Choo via GitGitGadget" <gitgitgadget@xxxxxxxxx> writes:

> From: Glen Choo <chooglen@xxxxxxxxxx>
>
> These are actually used as config callbacks, so use the typedef-ed type
> and make future refactors easier.
>
> Signed-off-by: Glen Choo <chooglen@xxxxxxxxxx>
> ---
>  urlmatch.h | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/urlmatch.h b/urlmatch.h
> index 9f40b00bfb8..bee374a642c 100644
> --- a/urlmatch.h
> +++ b/urlmatch.h
> @@ -2,6 +2,7 @@
>  #define URL_MATCH_H
>  
>  #include "string-list.h"
> +#include "config.h"
>  
>  struct url_info {
>  	/* normalized url on success, must be freed, otherwise NULL */
> @@ -48,8 +49,8 @@ struct urlmatch_config {
>  	const char *key;
>  
>  	void *cb;
> -	int (*collect_fn)(const char *var, const char *value, void *cb);
> -	int (*cascade_fn)(const char *var, const char *value, void *cb);
> +	config_fn_t collect_fn;
> +	config_fn_t cascade_fn;

Makes sense.

>  	/*
>  	 * Compare the two matches, the one just discovered and the existing
>  	 * best match and return a negative value if the found item is to be



[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux