Re: [PATCH v3 0/4] Changed path filter hash fix and version bump

[Jonathan Tan <jonathantanmy@xxxxxxxxxx>]

Junio C Hamano <gitster@xxxxxxxxx> writes:
> Perhaps an addition to Documentation/CodingGuidelines is in order?
> 
>  Documentation/CodingGuidelines | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git c/Documentation/CodingGuidelines w/Documentation/CodingGuidelines
> index 9d5c27807a..78bc60665d 100644
> --- c/Documentation/CodingGuidelines
> +++ w/Documentation/CodingGuidelines
> @@ -188,6 +188,15 @@ For shell scripts specifically (not exhaustive):
>     hopefully nobody starts using "local" before they are reimplemented
>     in C ;-)
>  
> + - In 'printf' format string, do not use hexadecimals, as they are not
> +   portable.  Write 
> +
> +     CENT=$(printf "\302\242")
> +
> +   not
> +
> +     CENT=$(printf "\xc2\xa2")

I've checked with "dash" and this applies to any quoted string, not just
when passed to printf. I'll prepare a patch describing this.