Re: [PATCH v5 2/2] gc: introduce `gc.recentObjectsHook`

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Glen Choo <chooglen@xxxxxxxxxx> writes:

> Taylor Blau <me@xxxxxxxxxxxx> writes:
>
>> When performing a garbage collection operation on a repository with
>> unreachable objects, Git makes its decision on what to do with those
>> object(s) bed on how recent the objects are or not. Generally speaking,
>
> s/bed/based/ ?

Indeed.  Also "or not" sounds a bit extraneous.

>> +		if (parse_oid_hex(buf.buf, &oid, &rest) || *rest) {
>> +			ret = error(_("invalid extra cruft tip: '%s'"), buf.buf);
>
> To be consistent with the other error message, perhaps s/extra cruft
> tip/additional recent object/?

Sharp eyes.

> Aside from those trivial points, everything looks good.

Thanks for reviewing (and writing).



[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux