Hi, On Mon, 22 Oct 2007, Shawn O. Pearce wrote: > Benoit SIGOURE <tsuna@xxxxxxxxxxxxx> wrote: > > >On Oct 4, 2007, at 1:18 AM, Junio C Hamano wrote: > > >>Benoit Sigoure <tsuna@xxxxxxxxxxxxx> writes: > > >> > > >>If we do not care about supporting too old GNU make, we can do > > >>this by first adding this near the top: > > >> > > >> ifndef NO_RPATH > > >> LINKER_PATH = -L$(1) $(CC_LD_DYNPATH)$(1) > > >> else > > >> LINKER_PATH = -L$(1) > > >> endif > > >> > > >>and then doing something like: > > >> > > >> CURL_LIBCURL = $(call LINKER_PATH,$(CURLDIR)/$(lib)) > > >> OPENSSL_LINK = $(call LINKER_PATH,$(OPENSSLDIR)/$(lib)) > > >> > > >>to make it easier to read and less error prone. > > > > > >Yes. I can rework the patch, but the question is: do you care > > >about old GNU make? Can I rewrite the patch with this feature? > > > > I know Junio is still offline but maybe someone else has an objection > > against this? > > How old of a GNU make are talking about here? The above is certainly a > lot nicer to read, but I'd hate to suddenly ship a new Git that someone > cannot compile because their GNU make is too old. I seem to remember remember that we had some shell quoting in the Makefile, and it was "call"ed. That broke some setups, so we got rid of it. *starting "git log -Scall Makefile"*: yep. It even was me fixing it, in 39c015c556f285106931e0500f301de462b0e46e. Ciao, Dscho - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
