On 08/06/2023 20:21, Jonathan Tan wrote: > Here's an updated version with changes only in the tests: > - resilience against unsigned-by-default (a "skip" will be shown) > - for systems that have different quoting behavior, the tests > will be skipped (see patch 2 for more information) > > Some of the test changes may seem a bit of a hack, so if you have > a better way of doing things, please let me know. > > I've also included a change to the file format specification. To > reviewers, if you generally agree that we need a version 2 but are still > unsure about how we should migrate, consider saying so and then perhaps > we can merge the first patch while the rest remain under review. This > will give other projects, like JGit, more certainty as to the direction > that the Git project wants to take. > > Jonathan Tan (4): > gitformat-commit-graph: describe version 2 of BDAT > t4216: test changed path filters with high bit paths > repo-settings: introduce commitgraph.changedPathsVersion > commit-graph: new filter ver. that fixes murmur3 > > Documentation/config/commitgraph.txt | 16 ++++- > Documentation/gitformat-commit-graph.txt | 9 ++- > bloom.c | 65 +++++++++++++++++- > bloom.h | 8 ++- > commit-graph.c | 29 ++++++-- > oss-fuzz/fuzz-commit-graph.c | 2 +- > repo-settings.c | 6 +- > repository.h | 2 +- > t/helper/test-bloom.c | 9 ++- > t/t0095-bloom.sh | 8 +++ > t/t4216-log-bloom.sh | 86 ++++++++++++++++++++++++ > 11 files changed, 219 insertions(+), 21 deletions(-) > > Range-diff against v2: > -: ---------- > 1: d4b63945f6 gitformat-commit-graph: describe version 2 of BDAT > 1: c587eb3470 ! 2: aa4535776e t4216: test changed path filters with high bit paths > @@ t/t4216-log-bloom.sh: test_expect_success 'Bloom generation backfills empty comm > +# chosen to be the same under all Unicode normalization forms > +CENT=$(printf "\xc2\xa2") I think the only change you need to make here (because /usr/bin/sh on Ubuntu is usually 'dash' not 'bash') is to use octal rather than hexadecimal. ie: CENT=$(printf "\302\242") HTH ATB, Ramsay Jones
