Elijah Newren <newren@xxxxxxxxx> writes: > There are two _different_ things named "struct dir_entry" in the codebase: In the longer term, we should rename such a local type to avoid name clashes with the global one. But I of course am OK to leave it outside the topic to clean it up. In any case, it is worth saying in the proposed log message why name-hash cannot use cache.h if we make it include dir.h; it is easy to do so (i.e. "it has its own 'dir_entry' that is used for other purpose"). Thanks.
