On Fri, Jun 2, 2023 at 3:33 AM Junio C Hamano <gitster@xxxxxxxxx> wrote:
> Kousik Sanagavarapu <five231003@xxxxxxxxx> writes:
> > I have also rebased this to be on top of v2.41.0, the previous version
> > was on top of v2.41.0-rc0.
>
> I am still feverish and feeling weak so no real review from me yet,
> but there is one thing that immediately jumped at me.
>
> > 1: 5c97d11b79 ! 1: 87465ef1a8 t/lib-gpg: introduce new prereq GPG2
> > @@ t/lib-gpg.sh: test_lazy_prereq GPG '
> > + test $? != 127 || exit 1
> > +
> > + case "$gpg_version" in
> > -+ !"gpg (GnuPG) 2."*)
> > ++ "gpg (GnuPG) 0."* | "gpg (GnuPG) 1.*")
>
> The last '*' being inside double-quote would not be what you
> intended, I suspect?
I noticed that, as well, when running my eye over the range-diff.
Moreover, I wondered if using `[01]` to avoid the repetition would be
worthwhile:
case "$gpg_version" in
"gpg (GnuPG) "[01].*)
though, of course, it's subjective whether that is clearer.
