"Glen Choo via GitGitGadget" <gitgitgadget@xxxxxxxxx> writes: > Outside of config.c, config callbacks now need to pass "kvi" to any of > the git_config_<type>() functions that parse a config string into a > number type. Included is a .cocci patch to make that refactor. In cases > where "kvi" would never be used, pass NULL, e.g.: > > - In config.c, when we are parsing a boolean instead of a number > - In builtin/config.c, when calling normalize_value() before setting > config to something the user gave us. In these cases, could we synthesize a kvi instead of using NULL? I believe there are already code paths that use an UNKNOWN scope - these seem similar to that. Otherwise looks good - a straightforward, mostly mechanical, change.
