Siddharth Singh <siddhartth@xxxxxxxxxx> wrote: > This RFC patch adds unit tests for khash.h. I agree with what Taylor said about being skeptical of these tests being productive. I'm curious about switching parts of git to use AC's newer `khashl'. khashl is smaller than the original khash but slower for deletes. Since git hardly deletes and khash memory use is high (especially on packing); it should be a benefit all around. Also, see Documentation/CodingGuidelines for coding style.