On Wed, May 24, 2023 at 02:48:40PM -0400, Eric Sunshine wrote: > On Wed, May 24, 2023 at 12:40 PM Taylor Blau <me@xxxxxxxxxxxx> wrote: > > Guard the checks to both of the above functions by first whether > > s/first/first checking/ Oops. Good eyes, thanks for spotting. > > @@ -2065,11 +2068,11 @@ static int prepare_to_clone_next_submodule(const struct cache_entry *ce, > > strvec_pushf(&child->args, "--filter=%s", > > expand_list_objects_filter_spec(suc->update_data->filter_options)); > > + strvec_pushl(&child->args, "--url", url, NULL); > > if (suc->update_data->require_init) > > strvec_push(&child->args, "--require-init"); > > strvec_pushl(&child->args, "--path", sub->path, NULL); > > strvec_pushl(&child->args, "--name", sub->name, NULL); > > - strvec_pushl(&child->args, "--url", url, NULL); > > This change is unnecessary now, isn't it? Or is there something > nonobvious going on here? Yeah, this is a stray diff. I'll send a cleaned up version as soon as 'make test' finishes ;-). Thanks, Taylor
